Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add manual notebook for lambda-K-Pi #101

Closed
wants to merge 6 commits into from
Closed

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented Aug 27, 2024

Using the exact same model for Eta-Pi-P as a test for Lambda-K-Pi in manual and flexible symbolic sympy way.

@shenvitor shenvitor added the 📝 Docs Improvements or additions to documentation label Aug 27, 2024
@shenvitor shenvitor self-assigned this Aug 27, 2024
@shenvitor shenvitor marked this pull request as draft August 27, 2024 16:29
@shenvitor shenvitor requested a review from a team August 27, 2024 16:29
@shenvitor shenvitor changed the title DOC: make manual notebook for lambda-K-Pi DOC: add manual notebook for lambda-K-Pi Aug 27, 2024
@shenvitor
Copy link
Member Author

shenvitor commented Aug 30, 2024

Screenshot 2024-08-30 at 18 23 30
The Dalitz plot in this PR looks awesome rn 🍡 !
(hopefully, it's correctly formulated, I will double-check later next week)

@shenvitor shenvitor marked this pull request as ready for review August 30, 2024 16:28
@redeboer redeboer marked this pull request as draft September 2, 2024 07:48
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the use of creating an (almost) exact copy of the eta pi p notebook. That one is more for playing around with a super simple amplitude model that has three subsystems and one resonance in each, where you can then see the effect of angular momentum. As we know, that model is not physical.

For $\Lambda K \pi$, we have to step up the game. This is supposed to be a model that formulates the model from the (preferably) ampform-dpd notebook manually, so that it can then be tweaked with a proper treatment of e.g. #58.

What is currently missing are multiple resonances, treatment of spin of the final-state particles, spin alignment, etc. That also makes the UI design not suitable. I would therefore start to try to reproduce the model (symbolic only!) from ampform-dpd.ipynb.

@@ -3,4 +3,5 @@
```{toctree}
ampform
ampform-dpd
manual-symbolic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why call this manual-symbolic, not manual?

@shenvitor
Copy link
Member Author

shenvitor commented Sep 2, 2024

I don't see the use of creating an (almost) exact copy of the eta pi p notebook. That one is more for playing around with a super simple amplitude model that has three subsystems and one resonance in each, where you can then see the effect of angular momentum. As we know, that model is not physical.

For $\Lambda K \pi$, we have to step up the game. This is supposed to be a model that formulates the model from the (preferably) ampform-dpd notebook manually, so that it can then be tweaked with a proper treatment of e.g. #58.

What is currently missing are multiple resonances, treatment of spin of the final-state particles, spin alignment, etc. That also makes the UI design not suitable. I would therefore start to try to reproduce the model (symbolic only!) from ampform-dpd.ipynb.

I think the idea here is to have multiple notebooks for symbolic manually in different levels of complications, from simplest to some more complicated ones later in this reaction section.

@redeboer
Copy link
Member

redeboer commented Sep 2, 2024

I think the idea here is to have multiple notebooks for symbolic manually in different levels of complications, from simplest to some more complicated ones later in this reaction section.

That's fine, but to have multiple copies of the same idea is just a maintenance burden. The 'manual' eta pi p notebook is just a pedagogical exercise: some spinless initial and final state ("p gamma to eta pi p" is even misleading) with one resonance per subsystem. In fact, the only difference between the two notebooks now are the labels of those three imaginary resonances and the imaginary final state (see #101 (comment)).

In the end, what we want to achieve is a physical description of $p\gamma \to \Lambda K \pi$, that is, with correct description of the production process, all dominating resonances in each subsystem, and a proper treatment of spin alignment of the final state. There is no generic package that can do that, so we need to go through a process of manually formulating each of these components to gain understanding of its behaviour.

@redeboer
Copy link
Member

redeboer commented Sep 2, 2024

I'm fine with adding this notebook, but a lot needs to be done to this PR first, for instance:

  • rotations for each decay node (see model from ampform.ipynb and ampform-dpd.ipynb)
  • a sum over an arbitrary number of resonances

@shenvitor
Copy link
Member Author

Okay, I see your points. Yup we can make it more accurate than now.

@shenvitor
Copy link
Member Author

Rejected by @redeboer, so close this as not planned for now, but we can still see the record if we need it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants