Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: activate Ruff formatting and linting in Jupyter Lab #63

Merged
merged 12 commits into from
Aug 1, 2024

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 1, 2024

Closes #48

  • 22622f6 updates lock file so that the next commits clearly show the changes to all dependencies
  • 828c85c, 87451bb, fac0cae, and bd1d74d remove redundant direct dependencies (that is, the packages that are imported in notebooks)
  • ac458d4 and 87e98fd address the Ruff linting errors found in Jupyter Lab. For some reason, the Ruff pre-commit hook does not find these. I assume this is because that hook deactivates some rules for Jupyter notebooks by default, while the `python-lsp-ruff

@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Aug 1, 2024
@redeboer redeboer requested a review from shenvitor August 1, 2024 08:03
@redeboer redeboer assigned shenvitor and redeboer and unassigned shenvitor Aug 1, 2024
@redeboer
Copy link
Member Author

redeboer commented Aug 1, 2024

@shenvitor could you check if Ruff works for you in Jupyter Lab if you follow the new instructions in ComPWA/compwa.github.io#287?

Copy link
Member

@shenvitor shenvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, approved!

@redeboer redeboer merged commit 58d04f8 into main Aug 1, 2024
4 checks passed
@redeboer redeboer deleted the jupyterlab-ruff branch August 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate Ruff linting in Jupyter Lab
2 participants