-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: demonstrate expression serialization #291
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
4bfb4fc
to
04e2f9b
Compare
Thanks for the PR!
Probably best addressed through ComPWA/ampform-dpd#44
I think
It is indeed complicated of a long-term solution for this: "use" depends on what the requirements of the target application are. This also points to a larger issue: so far, this repository was more like an application (an analysis), not a general-purpose library. We want to generalise the code now, but we have to decide what general functionality this library should provide. See also #224. |
@redeboer what is missing here for merging? |
We could merge it (it works), but the solution presented is copy-paste snippets, because there is no function that does the serialization for you. But we can also let this PR be limited to showing how to serialize so that it is at least in the documentation. |
for more information, see https://pre-commit.ci
The current github page docs do not have the section on the model serialization. Is it a matter of rerunning the tox job in CI? |
The first attempt to serialize symbolic model (
save-model.ipynb
) and reuse in a separate notebook (load-model.ipynb
)Currently, the model is saved as a pickle file that includes:
It would be useful to be able to retrieve the symbolic model with minimal dependencies.
Here are some things to discuss:
done
/substituted expressionsKibble
,BW
, ... - minimal library for lineshapes(?)