Add notebooks for Lecture 12 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lecture12_2_evaluateInvariantMass_gammap-solution.ipynb updates the solution notebook listed for lecture6 with the use of gdown package for retrieving the data
for more information, see https://pre-commit.ci
* DOC: make filename structure suitable for `lecture??.ipynb` pattern * ENH: switch to `gdown.cached_download()`
|
Thanks a lot @afilippi67! |
|
One of the notebooks might actually take a lot, it depends on the number of events I left in the loop… but that should be finished in some minutes. I need to take a look to spot if everything is ok (and reduce this number).
I didn’t expect they were going to be checked and run! How smart ;-)
Thanks
Alessandra
… On 8 Sep 2023, at 13:10, Remco de Boer ***@***.***> wrote:
Thanks a lot @afilippi67!
The notebooks are running under the checks for this PR now, but it seems that the angles notebook takes a long time. Should that be the case?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
I merged it before the checks are finished, so that (hopefully) the pages are updated in time for the lecture. |
redeboer
pushed a commit
to redeboer/strong2020-salamanca
that referenced
this pull request
Sep 9, 2023
* DOC: make filename structure suitable for `lecture??.ipynb` pattern * ENH: switch to `gdown.cached_download()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lecture12_2_evaluateInvariantMass_gammap-solution.ipynb updates the solution notebook listed for lecture6 with the use of gdown package for retrieving the data