Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the way to handle spectra type #133

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

f-idiris
Copy link
Contributor

@f-idiris f-idiris commented Sep 22, 2023

Data types and their associated layouts have been moved into a JSON file instead of being hard coded. An API for updating the data types and an API for sending the layouts have also been created.

@f-idiris f-idiris force-pushed the 130-update-the-way-to-handle-spectra-type branch 2 times, most recently from 2b06e13 to 1edde5f Compare September 27, 2023 13:49
@f-idiris f-idiris marked this pull request as ready for review September 28, 2023 08:15
@f-idiris f-idiris marked this pull request as draft September 29, 2023 09:32
@f-idiris f-idiris force-pushed the 130-update-the-way-to-handle-spectra-type branch from 1b0cc64 to 19d0816 Compare September 29, 2023 13:28
@f-idiris f-idiris force-pushed the 130-update-the-way-to-handle-spectra-type branch from 19d0816 to 594c57a Compare October 12, 2023 07:40
@baolanlequang baolanlequang marked this pull request as ready for review October 12, 2023 07:54
@f-idiris f-idiris force-pushed the 130-update-the-way-to-handle-spectra-type branch from 4933e5e to 26bd94c Compare October 16, 2023 14:32
@baolanlequang baolanlequang merged commit c333a54 into development Oct 25, 2023
1 check failed
baolanlequang pushed a commit that referenced this pull request Oct 30, 2023
* Map data types and spectra layouts

* FIx: process lower/mixed case data types
baolanlequang pushed a commit that referenced this pull request Nov 6, 2023
* Map data types and spectra layouts

* FIx: process lower/mixed case data types
baolanlequang pushed a commit that referenced this pull request Dec 11, 2023
* Map data types and spectra layouts

* FIx: process lower/mixed case data types
baolanlequang pushed a commit that referenced this pull request Dec 11, 2023
* Map data types and spectra layouts

* FIx: process lower/mixed case data types
baolanlequang pushed a commit that referenced this pull request Dec 11, 2023
* Map data types and spectra layouts
baolanlequang added a commit that referenced this pull request Dec 11, 2023
* Map data types and spectra layouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants