fixed failing test cases due to changes in chemotion ELN #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create user test and researchplan extended test are added * added identifier to eliminate flakyness in researcPlan cypress-specs * collections api spec is now added * deleted unnecessary comments from collection_api_spec.cy.js * Remove redundant API test for now (conceptually replicated RSpec) --------- Co-authored-by: Jan C. Brammer <[email protected]>
ComPlat#1412) * fix bug undefined current_user for collectionEntity on reaction docx report export * add current_user argument to ReactionReportEntity and do refactor spec files
* - tabs segment for sync collection entity - add css for tab cell sync collec entity to return empty tab_segment profile remove tab_segments from sync_collec_user entity * extract string utility function --------- Co-authored-by: Mehreen <mehreen.mansur> Co-authored-by: PiTrem <[email protected]>
* fix checkbox for `unsorted` list * select/deselect/delete for current page only * update renderCheckAll
* refactor the private_note_api.rb refactor the PrivateNoteFetcher.js refactor the private_note_api.spec.rb * fix rubocop warning
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ated_at * add the option to sort reactions based on short_label or updated_at * modify the test cases since default reaction sorting is based on short_label in place of updated_at * fix the sort query based on the action stated in the sort icon for reactions implement short_label descending sort for reactions modify sort icon texts modify the test cases as short_label desc sort is applied * modify the sort icon to display the current sort state modify the pop over text of the sort icon to describe the sorting action on click and also the current sort state Refs: ComPlat#1418
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mehreen <mehreen.mansur>
Refs: ComPlat#1431 Co-authored-by: Lan Le <[email protected]>
* modify the reaction list sorting to default to created_at as in < v1.7.0 disable the sort toggle for reaction list modify the sort icon popup text modify the test codes as reaction list is sorted by created_at by default Ref: ComPlat#1429
Refs: ComPlat#1425 Co-authored-by: Mehreen <mehreen.mansur>
* - include tab option from profile data - filter null values in hidden tab list Refs: ComPlat#1427 --------- Co-authored-by: Mehreen <mehreen.mansur> Co-authored-by: PiTrem <[email protected]>
Co-authored-by: Lan Le <[email protected]>
* fix the sort query based on the action stated in the sort icon for reactions Refs: ComPlat#1439
* fix the CSS for header comment buttons to keep them together on smaller screens fix the display of the comment count in the reactions' list * refactor the code to fix linting warnings * refactor the code show the action of the products only toggle button * add comment section for the inventory tab in samples Ref: ComPlat#1435
…ssues * Allow deletion of SampleTasks and fix SampleTask Inbox scroll issues * Add confirmation dialog when deleting a sample task * Improve deletion dialogue * Add spec for DELETE sample task endpoint * Rubocop Refs: ComPlat#1444
as the resource is being updated
* also refactor: schmooze implementation Refs: ComPlat#1458
JanCBrammer
requested changes
Aug 10, 2023
|
On Once that rebase is done, could you rebase |
* fix navigation to existing sample without permission: when a query to fetch sample by id returns 401, the not accessible panel should be rendered * now also render the info panel for record (sample/reaction) not found (404) Ref: ComPlat#1469
* fix: force rerendering after attachment preview change After changing/adding an attachment the preview variable of all attachments are reloaded, but the "refreshed" attachments are not set to the react state. I will force now a rerendering after the reload of the preview * style: eslint autofixes + method order fixes + react/destruct * test: add test for checking correct rendering Refs: ComPlat#1467
Co-authored-by: Lan Le <[email protected]> Refs: ComPlat#1374
mehmood86
force-pushed
the
end_to_end_tests_ext
branch
from
de9137e
to
849877d
Compare
|
Superseded by #1481; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release