Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Group Nodes : hidden in / outputs show + break on change #2397

Closed
PrometheusDante opened this issue Feb 2, 2025 · 2 comments · Fixed by #2399
Closed

[Bug]: Group Nodes : hidden in / outputs show + break on change #2397

PrometheusDante opened this issue Feb 2, 2025 · 2 comments · Fixed by #2399
Assignees
Labels
bug Something isn't working

Comments

@PrometheusDante
Copy link

PrometheusDante commented Feb 2, 2025

Frontend Version

ComfyUI_frontend v1.8.12
ComfyUI 0.3.13
ComfyUI-Manager V3.17.3

Expected Behavior

Inputs and outputs of group nodes should be hidden when toggled to be hidden, and not have any name changes.

Actual Behavior

All in- and outputs that were set to be hidden, but have auto-named unique descriptors, as it happens with nodes sharing widget names, are shown, resulting in a mess.
Editing an input's name to be empty and saving the group node, causes it disappear entirely from group node and the group node editor.

Image

Steps to Reproduce

Minimal workflow using a note and two grouped KSamplers

group_node_issue_minimal_workflow.json

Debug Logs

-

Browser Logs

Setting JSON

comfy.settings.json

What browsers do you use to access the UI ?

Mozilla Firefox

Other

Thank you for your time and hard work!

┆Issue is synchronized with this Notion page by Unito

@PrometheusDante PrometheusDante added the Potential Bug Untriaged bug label Feb 2, 2025
@webfiltered webfiltered self-assigned this Feb 2, 2025
@PrometheusDante
Copy link
Author

For anyone facing this issue: Using frontend v1.8.8. works as expected
→ I just appended --front-end-version Comfy-Org/[email protected] to Comfy's startup arguments in run_nvidia_gpu.bat

@christian-byrne
Copy link
Collaborator

Reproduction Steps:

  1. Open a new blank workflow
  2. Add 2 of the same node to the workflow
  3. Create a group node containing those 2 identical nodes
  4. Right click group node to open node right-click context menu
  5. Click Manage Group Node in the node right-click context menu
  6. In the Manage Group Node dialog, uncheck the Visible checkbox for one of the inputs belonging to one of the 2 identical nodes
  7. Export/save the workflow
  8. Reload the page or open a new workflow tab
  9. Load the saved workflow
  10. Observe that the hidden inputs are no longer hidden, despite the Manage Group Node dialog indicating that they are. On ComfyUI_frontend@=<1.8.8, the hidden status persists as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants