Revert "Correct node/output titles when grouping nodes (#2359) (#2370)" #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Yorha4D,
KarryCharon,
DorotaLuna and
shinshin86
as code owners
huchenlei
reviewed
Feb 2, 2025
Few seconds to slow I think! It's in the PR description. Was just double-checking the change in behaviour locally before linking. |
|
Since PrometheusDante provided a minimal test workflow in #2397, I can quickly add a test to this PR. |
|
That would be excellent to add in to a reland PR! This one is pure revert - no adds/removes. Usually prefer reverts that way (when it's remotely practical), as it makes it easier to backtrack. |
huchenlei
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cbcbeab.
#2359 / #2370 have broken old workflows that made heavy use of group nodes. As the original PR was non-critical, we can reland the PR behind a user setting that defaults off.
User report:
#2359 (comment)
┆Issue is synchronized with this Notion page by Unito