-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User Feedback buttons #2275
Conversation
f2dcfff
to
b90fa8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the feedback button as a badge in the about panel might not be the best design. Maybe we would want it to be in a separate section?
For this PR let's just drop the badge related change and only trigger feedback dialog with top dropdown menu, and leave the redesign of about panel to a separate PR.
src/types/comfy.ts
Outdated
icon: string | ||
} | ||
|
||
export type AboutPageBadge = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have extensions like ComfyUI-Manager adding custom badge to the about panel right now. Changing this interface would break their implementation.
Thank you! |
@christian-byrne I think the rating field can be further discussed separately. Currently we don't have feature category. The overall rating to the whole ComfyUI app might not be that useful. If later we can have feature tags, it might make more sense to add the rating. |
SGTM. In that case, I can actually simplify this a lot and just render the feedback dialog using the method in this #2284 |
I think the overall thinking process is that rating only gives value when the rating of one thing is compared with the rating of another thing. If there is only one category, then the value actually doesn't give much information to us. |
Okay, but this no longer requires its own component. It can use the same function to render dialog as the one proposed in #2284. So let me simplify the two PR into one. |
Generally better to use passthrough: <ReportIssuePanel
error-type="Feedback"
:title="$t('issueReport.feedbackTitle')"
:default-fields="['SystemStats', 'Settings']"
:pt="{
root: {
class: 'border-none'
}
}" |
This PR adds a Feedback button to the Help topmenu submenu, which opens the feedback dialog, allowing users to send any feedback they have.
On desktop, a feedback button already existed which linked to Comfy Forum - Desktop v1 Feedback. This PR replaces it. It can be re-added as a separate button later.
┆Issue is synchronized with this Notion page by Unito