Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Feedback buttons #2275

Merged
merged 29 commits into from
Jan 20, 2025
Merged

Add User Feedback buttons #2275

merged 29 commits into from
Jan 20, 2025

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 17, 2025

This PR adds a Feedback button to the Help topmenu submenu, which opens the feedback dialog, allowing users to send any feedback they have.

feedback-buttons

On desktop, a feedback button already existed which linked to Comfy Forum - Desktop v1 Feedback. This PR replaces it. It can be re-added as a separate button later.

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne marked this pull request as ready for review January 17, 2025 22:16
@sync-by-unito sync-by-unito bot closed this Jan 18, 2025
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the feedback button as a badge in the about panel might not be the best design. Maybe we would want it to be in a separate section?

For this PR let's just drop the badge related change and only trigger feedback dialog with top dropdown menu, and leave the redesign of about panel to a separate PR.

icon: string
}

export type AboutPageBadge =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have extensions like ComfyUI-Manager adding custom badge to the about panel right now. Changing this interface would break their implementation.

@huchenlei
Copy link
Member

huchenlei commented Jan 19, 2025

Changes:

  • Replace non-existing menuLabels.Feedback with g.feedback.
  • Add min-w to the dialog so that the dialog holds proper width even in other locales.
    image
    image
  • Validate email format

@christian-byrne
Copy link
Collaborator Author

Changes:

  • Replace non-existing menuLabels.Feedback with g.feedback.
  • Add min-w to the dialog so that the dialog holds proper width even in other locales.

Thank you!

@huchenlei
Copy link
Member

@christian-byrne I think the rating field can be further discussed separately. Currently we don't have feature category. The overall rating to the whole ComfyUI app might not be that useful. If later we can have feature tags, it might make more sense to add the rating.

Ref:
https://issues.chromium.org/issues/390936402
image

@christian-byrne
Copy link
Collaborator Author

SGTM. In that case, I can actually simplify this a lot and just render the feedback dialog using the method in this #2284

@huchenlei
Copy link
Member

huchenlei commented Jan 20, 2025

SGTM. In that case, I can actually simplify this a lot and just render the feedback dialog using the method in this #2284

I think the overall thinking process is that rating only gives value when the rating of one thing is compared with the rating of another thing. If there is only one category, then the value actually doesn't give much information to us.

@huchenlei
Copy link
Member

UI after change:

image

@christian-byrne
Copy link
Collaborator Author

Okay, but this no longer requires its own component. It can use the same function to render dialog as the one proposed in #2284. So let me simplify the two PR into one.

@huchenlei
Copy link
Member

Okay, but this no longer requires its own component. It can use the same function to render dialog as the one proposed in #2284. So let me simplify the two PR into one.

Let's merge this PR and refactor it to support #2284.

@huchenlei huchenlei merged commit a1ed67f into main Jan 20, 2025
10 checks passed
@huchenlei huchenlei deleted the feedback-button branch January 20, 2025 00:42
@christian-byrne
Copy link
Collaborator Author

<style scoped>
:deep(.p-panel) {
@apply border-none;
}
</style>

Generally better to use passthrough:

    <ReportIssuePanel
      error-type="Feedback"
      :title="$t('issueReport.feedbackTitle')"
      :default-fields="['SystemStats', 'Settings']"
      :pt="{
        root: {
          class: 'border-none'
        }
      }"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants