Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forms plugin to issue report component #2302

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Add forms plugin to issue report component #2302

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7228324
Update issue reporting components and dependencies
christian-byrne Jan 20, 2025
de2b478
Update unit tests
christian-byrne Jan 20, 2025
446d8c0
add missing translation
christian-byrne Jan 20, 2025
ccf0daa
add missing translation
christian-byrne Jan 20, 2025
c3708b3
add notation on workaround
christian-byrne Jan 20, 2025
c857404
remove primevue type declaration
christian-byrne Jan 20, 2025
c4b2db1
get field data concurrently
christian-byrne Jan 21, 2025
b88f216
allow adding valid email but then deleting
christian-byrne Jan 21, 2025
344780b
Merge branch 'main' into vue-forms-report
christian-byrne Jan 21, 2025
2ede231
don't show textarea error after deleting all fields
christian-byrne Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"@atlaskit/pragmatic-drag-and-drop": "^1.3.1",
"@comfyorg/comfyui-electron-types": "^0.4.11",
"@comfyorg/litegraph": "^0.8.60",
"@primevue/forms": "^4.2.5",
"@primevue/themes": "^4.0.5",
"@sentry/vue": "^8.48.0",
"@tiptap/core": "^2.10.4",
Expand Down
40 changes: 0 additions & 40 deletions src/components/common/CheckboxGroup.vue
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/components/dialog/content/ExecutionErrorDialogContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ const stackTraceField = computed<ReportField>(() => {
label: t('issueReport.stackTrace'),
value: 'StackTrace',
optIn: true,
data: {
getData: () => ({
nodeType: props.error.node_type,
stackTrace: props.error.traceback?.join('\n')
}
})
}
})

Expand Down
7 changes: 3 additions & 4 deletions src/components/dialog/content/IssueReportDialogContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
}"
>
<template #header>
<header class="flex flex-col items-center">
<header class="flex flex-col items-center w-full">
<h2 id="issue-report-title" class="text-4xl">{{ title }}</h2>
<span v-if="subtitle" class="text-muted mt-2">{{ subtitle }}</span>
<span v-if="subtitle" class="text-muted mt-0">{{ subtitle }}</span>
</header>
</template>
<ReportIssuePanel v-bind="panelProps" :pt="{ root: 'border-none' }" />
Expand All @@ -20,10 +20,9 @@
<script setup lang="ts">
import Panel from 'primevue/panel'

import ReportIssuePanel from '@/components/dialog/content/error/ReportIssuePanel.vue'
import type { IssueReportPanelProps } from '@/types/issueReportTypes'

import ReportIssuePanel from './error/ReportIssuePanel.vue'

defineProps<{
title: string
subtitle?: string
Expand Down
Loading
Loading