Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Desktop maintenance task runner #2311

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[Refactor] Desktop maintenance task runner #2311

merged 2 commits into from
Jan 22, 2025

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 21, 2025 •
edited by sync-by-unito bot
Loading

Optional refactor

  • Follow-up of [Desktop] Startup maintenance screen #2253
  • Moves the minutia of task execution and state update out to a new MaintenanceClassRunner
  • Renames getState to getRunner, but otherwise maintains the API of the pinia store

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner January 21, 2025 21:38
@webfiltered
Copy link
Contributor Author

Just follow-up for what I thought felt right. Feel free to close / edit as you see fit!

@huchenlei huchenlei merged commit cd5283c into main Jan 22, 2025
10 checks passed
@huchenlei huchenlei deleted the task-runner branch January 22, 2025 01:18
@huchenlei huchenlei added the Electron ComfyUI Desktop related label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
Electron ComfyUI Desktop related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei