Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial workflow function for new desktop users #2315

Merged
merged 11 commits into from
Jan 25, 2025
Merged

Conversation

christian-byrne
Copy link
Collaborator

@christian-byrne christian-byrne commented Jan 22, 2025

This PR adds a function in workflow service that loads a tutorial workflow for first time users on the desktop app.

Currently it just loads the default workflow with model information. The option to show missing models dialog is set to true to help download the missing model.

┆Issue is synchronized with this Notion page by Unito

src/scripts/app.ts Outdated Show resolved Hide resolved
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made:

  • Set default value of TurotialCompleted to false.
  • Load default.json from template to avoid using mismatched URL.
  • Call loadModelFolders explicitly before loadTutorialWorkflow.
  • Add playwright test to verify the dialog appears.

@huchenlei huchenlei requested a review from a team as a code owner January 25, 2025 17:11
@huchenlei huchenlei merged commit e992bd6 into main Jan 25, 2025
10 checks passed
@huchenlei huchenlei deleted the default-wf-desktop branch January 25, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants