Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Persist troubleshooting terminal when hidden #2398

Merged
merged 4 commits into from
Feb 2, 2025
Merged

[Desktop] Persist troubleshooting terminal when hidden #2398

merged 4 commits into from
Feb 2, 2025
+115 −18

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Feb 2, 2025 •
edited by sync-by-unito bot
Loading

Current

  • PrimeVue Drawer forcibly destroys its contents when closed.

Proposed

  • All command output is buffered to a non-volatile, optimised xterm buffer.
  • Buffer is copied to the Drawer terminal when the component is created (every time the Drawer is opened).

┆Issue is synchronized with this Notion page by Unito

@socket-security Socket Security
Copy link

socket-security bot commented Feb 2, 2025 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@xterm/[email protected] None 0 162 kB tyriar

View full report↗︎

@webfiltered webfiltered changed the title [Desktop] Persist troubleshooting command output when Drawer closed [Desktop] Persist troubleshooting terminal when hidden Feb 2, 2025
@huchenlei huchenlei merged commit 5f59fbd into main Feb 2, 2025
2 checks passed
@huchenlei huchenlei deleted the console-drawer-retention branch February 2, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

@Yorha4D Yorha4D Awaiting requested review from Yorha4D Yorha4D is a code owner

@KarryCharon KarryCharon Awaiting requested review from KarryCharon KarryCharon is a code owner

@DorotaLuna DorotaLuna Awaiting requested review from DorotaLuna DorotaLuna is a code owner

@shinshin86 shinshin86 Awaiting requested review from shinshin86 shinshin86 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei