Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Impl i18n context menu translation #2425

Merged
merged 9 commits into from
Feb 5, 2025
Merged

[i18n] Impl i18n context menu translation #2425

merged 9 commits into from
Feb 5, 2025

Conversation

KarryCharon
Copy link
Collaborator

@KarryCharon KarryCharon commented Feb 5, 2025 •
edited by sync-by-unito bot
Loading

RePR: #2394 (comment)

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action i18n Anything related to translation labels Feb 5, 2025
@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Feb 5, 2025
huchenlei
huchenlei reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made:

  • Moved translation logic to src/hooks/translationHooks.ts and fixed many ts-strict errors.
  • Moved context menu translation keys to contextMenu namespace.

@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Feb 5, 2025
@huchenlei huchenlei merged commit 2c12df1 into main Feb 5, 2025
9 of 10 checks passed
@huchenlei huchenlei deleted the context-menu-translation branch February 5, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

@Yorha4D Yorha4D Awaiting requested review from Yorha4D Yorha4D is a code owner

@DorotaLuna DorotaLuna Awaiting requested review from DorotaLuna DorotaLuna is a code owner

@shinshin86 shinshin86 Awaiting requested review from shinshin86 shinshin86 is a code owner

Assignees
No one assigned
Labels
i18n Anything related to translation New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarryCharon @huchenlei