Refresh Preview3D node with node.onMouseEnter #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kvick-games thanks for the update, could you help adding the same fix into another three nodes? |
Sure, I added the same calls into the other 3 nodes, Load3D, Load3DAnimation and Preview3DAnimation |
jtydhr88
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Preview3D node is frequently in an invalid state and this is just a quick change to refresh the viewport on mouse enter over the node to improve the UX without drastically affecting perf.
Internally this calls resize because it seems like there are some initialization order issues going on, the viewport always boots up in an invalid state, so a better fix long term would be ideal.
┆Issue is synchronized with this Notion page by Unito