[Cleanup] Remove duplicated group header drawing logic #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof, sorry. I meant to address this months ago. I believe it was unintentionally left in when I (or you?) added header drawing into litegraph, so this is technically fixing a long-standing regression. Just flagging in case it is relevant: I paused on the change because it changed the alpha of the group headers slightly. |
The alpha change is probably so slight that playwright screenshot comparison is not even complaining haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group titlebar drawing has already been implemented in litegraph here: https://github.com/Comfy-Org/litegraph.js/blob/9d5e94859ed7b5668ae31f3d772848ded6e8f9de/src/LGraphGroup.ts#L158-L163
This PR removes the duplicated drawing logic.
┆Issue is synchronized with this Notion page by Unito