Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Manage comfyui-body elements with Vue #2522

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[Refactor] Manage comfyui-body elements with Vue #2522

merged 2 commits into from
Feb 11, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Feb 11, 2025

Ref: #2467 (comment)

This refactor will make it possible for DOMWidget to mount vue component under the main vue app instead of creating a new vue app.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner February 11, 2025 22:29
@huchenlei
Copy link
Member Author

Test failure due to slight diff on canvas menu style:
image

@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Feb 11, 2025
@github-actions github-actions bot requested a review from a team as a code owner February 11, 2025 22:59
@huchenlei huchenlei merged commit 9017513 into main Feb 11, 2025
2 checks passed
@huchenlei huchenlei deleted the app_layout branch February 11, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant