Add installation validation #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinjhuang
reviewed
Jan 14, 2025
robinjhuang
reviewed
Jan 14, 2025
webfiltered
force-pushed
the
virtual-validation
branch
2 times, most recently
from
0b356f9 to
6dd91e1
Compare
Add basic validation for venv, UV, and python Until UI is in place to perform auto-fix / ignore issues, validation should only log issues. Add basic validation for venv, UV, and python Instantiate venv object earlier: allows validation [Refactor] Simplify code: pass ComfyInstallation Ensure users can still start app if validation fails Add install validation Validate ComfyUI core venv reqs on startup Add terminal IPC Fix ipc return value passed Add VC redist & handlers Add uv clear and reset Add current working directory for uv command. Helps it find the correct .venv to run pip in. nit - Remove completed TODO [skip ci] nit nit Remove redundant code Fix basePath check ignored when upgrading config Load maintenance page on first validation error Allow uninstall / reinstall if startup fails nit - ESLint nit nit [Refactor] Remove redundant code
huchenlei
force-pushed
the
virtual-validation
branch
from
5807b31 to
78f4c3b
Compare
huchenlei
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation validation
Requires:
Validates the following on startup:
Adds maintenance tasks available through IPC:
┆Issue is synchronized with this Notion page by Unito