-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Provider: Azure DevOps #187
Conversation
are we only intending to support the push event? Azure devops (afaik) is a full git service. |
Ah, for some reason Azure calls them service hooks, versus webhooks so I missed the service hooks entirely. https://docs.microsoft.com/en-us/azure/devops/service-hooks/events?view=azure-devops I'll get those updated and added to the PR. Sorry about that. |
Take your time, make sure it's tested. |
Can you add this wrapper for Azure pipelines? Seems all is fine. I mean add for the site. |
What's the status of this PR? Will it work for push events if merged? |
|
||
public async gitPush(): Promise<void> { | ||
this.logger.debug('Parsing git push event') | ||
this.embed.title = this.body.message.markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't use markdown in the title of an embed. You should use this.body.message.text
instead.
Currently, the provider puts markdown in the title of the embed, which has the following ugly result: When you change Still not perfect though, but this is because DevOps puts a link in parentheses in the
Maybe we should remove this link from the message using regex? On a sidenote, is it intended that git tag events are also picked up? |
eventType
and adds that to ax-skyhook-event
headerLook in Discord: