Update to support chunked transfer #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 'writeExistingTransfer' downloads from main indy. Does indy get the headers from remote site then inherits the 'chunked'? |
I checked to print the header from gateway or indy directly, seems there is But the generic proxy side (okhttp3.response) will always include that no matter pointing to gateway or indy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for MMENG-4165, there are issues with incomplete downloads and failures when using curl/wget on prod.
After checking, it's caused by that it response with chunked way but wrong format in body, this adds the support for that based on the doc: https://www.rfc-editor.org/rfc/rfc9112#field.transfer-encoding
I test it with wget and curl in both ubi7 & ubi8, works well and will test it on dev later.