Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waitfor For Meilisearch #183

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add Waitfor For Meilisearch #183

merged 4 commits into from
Oct 29, 2024

Conversation

Alirexaa
Copy link
Member

@Alirexaa Alirexaa commented Oct 29, 2024

Closes #73

This pull request introduces several enhancements and bug fixes to the CommunityToolkit.Aspire.Hosting.Meilisearch project, including the addition of health checks and the reactivation of previously commented-out code. The most important changes are summarized below:

Enhancements:

Bug Fixes:

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@Alirexaa Alirexaa marked this pull request as ready for review October 29, 2024 19:03
@Alirexaa Alirexaa changed the title WIP: Add Waitfor For Meilisearch Add Waitfor For Meilisearch Oct 29, 2024
@Alirexaa Alirexaa added the enhancement New feature or request label Oct 29, 2024
@Alirexaa Alirexaa added this to the aspire-9 milestone Oct 29, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder 100% 100% 6
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder.AppHost 50% 100% 2
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder.BlazorApp 4% 0% 52
CommunityToolkit.Aspire.Hosting.Azure.DataApiBuilder.ServiceDefaults 0% 0% 14
CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps 100% 100% 28
CommunityToolkit.Aspire.Hosting.Deno 84% 75% 72
CommunityToolkit.Aspire.Hosting.Deno.AppHost 100% 100% 2
CommunityToolkit.Aspire.Hosting.Golang 94% 50% 16
CommunityToolkit.Aspire.Hosting.Golang.AppHost 100% 100% 2
CommunityToolkit.Aspire.Hosting.Java 98% 71% 58
CommunityToolkit.Aspire.Hosting.Java.AppHost 50% 100% 2
CommunityToolkit.Aspire.Hosting.Meilisearch 61% 27% 94
CommunityToolkit.Aspire.Hosting.Meilisearch.AppHost 50% 100% 2
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions 90% 68% 92
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.AppHost 100% 100% 2
CommunityToolkit.Aspire.Hosting.Ollama 52% 32% 154
CommunityToolkit.Aspire.Hosting.Ollama.AppHost 50% 100% 2
CommunityToolkit.Aspire.Meilisearch 97% 92% 68
CommunityToolkit.Aspire.OllamaSharp 92% 80% 30
CommunityToolkit.Aspire.StaticWebApps.AppHost 100% 100% 2
CommunityToolkit.Aspire.Testing 54% 50% 446
Summary 64% (1759 / 2744) 50% (416 / 824) 1146

Minimum allowed line rate is 60%

@aaronpowell aaronpowell merged commit 4052f0b into main Oct 29, 2024
9 checks passed
@aaronpowell aaronpowell deleted the alirexaa/meilisearch-waitfor branch October 29, 2024 23:38
@Alirexaa Alirexaa mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health checks
2 participants