Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73
This pull request introduces several enhancements and bug fixes to the
CommunityToolkit.Aspire.Hosting.Meilisearch
project, including the addition of health checks and the reactivation of previously commented-out code. The most important changes are summarized below:Enhancements:
src/CommunityToolkit.Aspire.Hosting.Meilisearch/CommunityToolkit.Aspire.Hosting.Meilisearch.csproj
: AddedMeilisearchHealthCheck.cs
to the project.src/CommunityToolkit.Aspire.Hosting.Meilisearch/MeilisearchBuilderExtensions.cs
: Integrated health checks for Meilisearch resources and ensured the health check key is added to the builder. [1] [2]Bug Fixes:
src/CommunityToolkit.Aspire.Hosting.Meilisearch/MeilisearchBuilderExtensions.cs
: Reactivated the subscription toConnectionStringAvailableEvent
and health check registration code.tests/CommunityToolkit.Aspire.Hosting.Meilisearch/MeilisearchFunctionalTests.cs
: Reactivated theVerifyWaitForOnMeilisearchBlocksDependentResources
test to ensure dependent resources wait for Meilisearch health checks.PR Checklist
Other information