-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Meilisearch integration #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the WIP as it stands and my only concern is that I'm not sure if we should be shipping the config schema stuff as part of the Community Toolkit packages.
...pire.CommunityToolkit.Hosting.Meilisearch/Aspire.CommunityToolkit.Hosting.Meilisearch.csproj
Outdated
Show resolved
Hide resolved
...pire.CommunityToolkit.Hosting.Meilisearch/Aspire.CommunityToolkit.Hosting.Meilisearch.csproj
Outdated
Show resolved
Hide resolved
src/Aspire.CommunityToolkit.Meilisearch/Aspire.CommunityToolkit.Meilisearch.csproj
Outdated
Show resolved
Hide resolved
...pire.CommunityToolkit.Hosting.Meilisearch/Aspire.CommunityToolkit.Hosting.Meilisearch.csproj
Outdated
Show resolved
Hide resolved
src/Aspire.CommunityToolkit.Meilisearch/Aspire.CommunityToolkit.Meilisearch.csproj
Outdated
Show resolved
Hide resolved
tests/Aspire.CommunityToolkit.Hosting.Meilisearch/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/Aspire.CommunityToolkit.Hosting.Meilisearch/MeilisearchFunctionalTests.cs
Outdated
Show resolved
Hide resolved
tests/Aspire.CommunityToolkit.Meilisearch.Tests/AspireMeilisearchClientExtensionsTest.cs
Outdated
Show resolved
Hide resolved
tests/Aspire.CommunityToolkit.Testing/Aspire.CommunityToolkit.Testing.csproj
Outdated
Show resolved
Hide resolved
tests/Aspire.CommunityToolkit.Testing/TestDistributedApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
@aaronpowell, I want to add https://github.com/riccox/meilisearch-ui as the UI dashboard but this PR got too large, So I will add that in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add Microsoft.DotNet.XUnitExtensions
so that we can better sync with the aspire core tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just updated the naming to match the new requirements of #124 and assuming the build passes it'd good to merge
Closes #65
This pull request includes several updates to the
Aspire.CommunityToolkit.sln
file, new project additions, and updates to dependencies. The most important changes include the addition of new Meilisearch projects, updates to project references, and the introduction of new dependencies.Project Additions and Updates:
Aspire.CommunityToolkit.Hosting.Meilisearch
,Aspire.CommunityToolkit.Meilisearch
, and their respective test and example projects. (Aspire.CommunityToolkit.sln
) [1] [2]{9A19103F-16F7-4668-BE54-9A1E7A4F7556}
GUID instead of{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}
. (Aspire.CommunityToolkit.sln
) [1] [2]Dependency Updates:
Directory.Packages.props
, includingMicrosoft.Extensions.Configuration.Binder
,Microsoft.Extensions.Hosting.Abstractions
,Microsoft.DotNet.XUnitExtensions
, andMeiliSearch
. (Directory.Packages.props
) [1] [2]Testcontainers
version3.10.0
inDirectory.Build.props
. (Directory.Build.props
)Code Ownership:
CODEOWNERS
file to include new Meilisearch projects and assigned ownership to@alirexaa
. (CODEOWNERS
)New Example Project:
Movie
class. (examples/meilisearch/Aspire.CommunityToolkit.Hosting.Meilisearch.ApiService
) [1] [2]PR Checklist
Other information
Add new testing tools: