Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meilisearch integration #66

Merged
merged 25 commits into from
Oct 22, 2024
Merged

Add Meilisearch integration #66

merged 25 commits into from
Oct 22, 2024

Conversation

Alirexaa
Copy link
Member

@Alirexaa Alirexaa commented Oct 4, 2024

Closes #65

This pull request includes several updates to the Aspire.CommunityToolkit.sln file, new project additions, and updates to dependencies. The most important changes include the addition of new Meilisearch projects, updates to project references, and the introduction of new dependencies.

Project Additions and Updates:

  • Added new Meilisearch projects to the solution, including Aspire.CommunityToolkit.Hosting.Meilisearch, Aspire.CommunityToolkit.Meilisearch, and their respective test and example projects. (Aspire.CommunityToolkit.sln) [1] [2]
  • Updated project references in the solution file to use the {9A19103F-16F7-4668-BE54-9A1E7A4F7556} GUID instead of {FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}. (Aspire.CommunityToolkit.sln) [1] [2]

Dependency Updates:

  • Added new dependencies in Directory.Packages.props, including Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Hosting.Abstractions, Microsoft.DotNet.XUnitExtensions, and MeiliSearch. (Directory.Packages.props) [1] [2]
  • Introduced Testcontainers version 3.10.0 in Directory.Build.props. (Directory.Build.props)

Code Ownership:

  • Updated the CODEOWNERS file to include new Meilisearch projects and assigned ownership to @alirexaa. (CODEOWNERS)

New Example Project:

  • Added a new example project for Meilisearch API service, including the project file and a Movie class. (examples/meilisearch/Aspire.CommunityToolkit.Hosting.Meilisearch.ApiService) [1] [2]

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • New integration
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Add new testing tools:

@Alirexaa Alirexaa added the integration A new .NET Aspire integration label Oct 4, 2024
@Alirexaa Alirexaa self-assigned this Oct 4, 2024
Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the WIP as it stands and my only concern is that I'm not sure if we should be shipping the config schema stuff as part of the Community Toolkit packages.

@Alirexaa Alirexaa mentioned this pull request Oct 17, 2024
10 tasks
@Alirexaa Alirexaa marked this pull request as ready for review October 18, 2024 17:06
@Alirexaa Alirexaa changed the title WIP: Add Meilisearch integration Add Meilisearch integration Oct 18, 2024
@Alirexaa
Copy link
Member Author

@aaronpowell, I want to add https://github.com/riccox/meilisearch-ui as the UI dashboard but this PR got too large, So I will add that in another PR.

Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add Microsoft.DotNet.XUnitExtensions so that we can better sync with the aspire core tests

Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just updated the naming to match the new requirements of #124 and assuming the build passes it'd good to merge

@Alirexaa Alirexaa merged commit 73ed325 into main Oct 22, 2024
10 checks passed
@Alirexaa Alirexaa deleted the alirexaa/meilisearch branch October 22, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration A new .NET Aspire integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Meilisearch integration
2 participants