Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DISA STIG for SLES 12 and SLES 15 #11293

Closed
wants to merge 7 commits into from

Conversation

hagenest
Copy link
Contributor

@hagenest hagenest commented Nov 21, 2023

Description:

I updated the XML file for DISA-STIG SLES 12 adn SLES 15 to the newest versions

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

Hi @hagenest. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hagenest hagenest changed the title Update DISA STIG for SLES 12 to V2 R12 Update DISA STIG for SLES 12 and SLES 15 Nov 21, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. labels Nov 21, 2023
@marcusburghardt marcusburghardt added this to the 0.1.71 milestone Nov 21, 2023
@vojtapolasek vojtapolasek modified the milestones: 0.1.71, 0.1.72 Nov 28, 2023
@hagenest hagenest requested a review from a team as a code owner December 5, 2023 09:27
Copy link

codeclimate bot commented Dec 5, 2023

Code Climate has analyzed commit bc8ca30 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes looks great but the PR needs some git housekeeping.
Please drop the empty merge commits and leave only the ones with the code changes. Preferably don't use your master branch as source, as most probably this creates confusion.

@hagenest hagenest closed this Dec 7, 2023
@vojtapolasek vojtapolasek added the Update Profile Issues or pull requests related to Profiles updates. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants