Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined notes and rules for control BSI APP4.4.A10 #11393

Merged

Conversation

benruland
Copy link
Contributor

@benruland benruland commented Dec 18, 2023

Description:

Notes / Rules for BSI APP4.4.A10 added.

This PR needs to be merged after #11342, as it builds upon the created skeleton in that PR. ✅

Rationale:

As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 18, 2023
Copy link

openshift-ci bot commented Dec 18, 2023

Hi @benruland. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marcusburghardt marcusburghardt added the OpenShift OpenShift product related. label Dec 18, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@benruland benruland changed the title Create rules for control BSI APP4.4.A10 Created rules for control BSI APP4.4.A10 Dec 18, 2023
@benruland benruland changed the title Created rules for control BSI APP4.4.A10 Created assessment for control BSI APP4.4.A10 Dec 18, 2023
@benruland benruland changed the title Created assessment for control BSI APP4.4.A10 Defined notes and rules for control BSI APP4.4.A10 Dec 18, 2023
@benruland benruland force-pushed the bsi-app-4.4-a10 branch 2 times, most recently from 0f8445e to 075170f Compare December 18, 2023 15:02
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jan 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jan 10, 2024
@benruland
Copy link
Contributor Author

The failing tests seem to be caused by testing infrastructure. I rebased the branch for re-testing.

The PR is now ready for review.

controls/bsi_app_4_4.yml Outdated Show resolved Hide resolved
@yuumasato yuumasato self-assigned this Jan 19, 2024
@yuumasato yuumasato added the BSI PRs or issues for the BSI profile. label Jan 19, 2024
@yuumasato yuumasato added this to the 0.1.72 milestone Jan 19, 2024
@benruland benruland force-pushed the bsi-app-4.4-a10 branch 3 times, most recently from 25fe0a5 to a7d10f2 Compare January 24, 2024 15:28
@marcusburghardt marcusburghardt modified the milestones: 0.1.72, 0.1.73 Jan 29, 2024
Copy link

codeclimate bot commented Feb 8, 2024

Code Climate has analyzed commit 9155443 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.4% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato merged commit 9a72a41 into ComplianceAsCode:master Feb 15, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSI PRs or issues for the BSI profile. needs-ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants