Fix Ansible compatibility with sysctl module #11537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of Ansible, such as the version included with RHEL7, the sysctl module was part of the ansible.builtin collection. But in most recent versions it belongs to the ansible.posix collection. Since explicity collection is not mandadotory, we can leave it implicit for this particular case so each Ansible version can manage it properly.
marcusburghardt
added
RHEL7
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
/packit retest-failed |
|
Code Climate has analyzed commit 6319439 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In older versions of Ansible, such as the version included with RHEL7, the
sysctlmodule was part of theansible.builtincollection. But in most recent versions it belongs to theansible.posixcollection.Since explicit collection is not mandatory, we can leave it implicit for this particular case so each Ansible version can manage it properly.
Rationale: