Add stigrefs after references from controls #11591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the step of adding a stigref to a later stage in the process, specifically from the moment rule.yml files are loaded to the time when references from controls are already added to rules. This change will allow us in future to use control file as the source of stigids. Up until now we can't do it because adding stigrefs depend on existence of stigid key in references in the rule object. If we want to add stigids from control files we need to add stigrefs after stigids are added, which means after controls are processed instead of during original rule.yml files.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit ce132fb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
|
/packit build |
1 similar comment
|
/packit build |
Mab879
approved these changes
Feb 15, 2024
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the step of adding a stigref to a later stage in the process, specifically from the moment rule.yml files are loaded to the time when references from controls are already added to rules.
Rationale:
This change will allow us in future to use control file as the source of stigids. Up until now we can't do it because adding stigrefs depend on existence of stigid key in references in the rule object. If we want to add stigids from control files we need to add stigrefs after stigids are added, which means after controls are processed instead of during processing the original rule.yml files.
Review Hints:
Build product and check the
stigrefkeys in resolved rules (build/rhel9/rules) and/or in the built data stream.