Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide profiles not in good shape for RHEL #11595

Conversation

marcusburghardt
Copy link
Member

Description:

There are some profiles introduced long time ago but no longer maintained. For compatibility purposes they are not removed from datastream but are now hidden to prevent people from using them.

Rationale:

  • Discourage the use of profiles no longer maintained and not in good shape.

Review Hints:

./build_product rhel7 rhel8
oscap info build/ssg-rhel7-ds.xml
oscap info build/ssg-rhel8-ds.xml

@marcusburghardt marcusburghardt added the RHEL Red Hat Enterprise Linux product related. label Feb 16, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Feb 16, 2024
@marcusburghardt marcusburghardt requested a review from a team as a code owner February 16, 2024 09:13
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt force-pushed the hide_not_complete_profiles_rhel branch 2 times, most recently from 18b5842 to 3b13ac8 Compare February 16, 2024 09:51
There are some profiles introduced long time ago but no longer
maintained. For compatibility purposes they are not removed from
datastream but are now hidden for RHEL8 to prevent people from
using them.
@marcusburghardt marcusburghardt force-pushed the hide_not_complete_profiles_rhel branch from 3b13ac8 to e0f62e3 Compare February 16, 2024 11:08
Copy link

codeclimate bot commented Feb 16, 2024

Code Climate has analyzed commit e0f62e3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Feb 16, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiding these profiles makes sense because these profiles are of an unknown quality and aren't developed actively.

@jan-cerny jan-cerny added RHEL8 Red Hat Enterprise Linux 8 product related. and removed RHEL Red Hat Enterprise Linux product related. labels Feb 16, 2024
@jan-cerny jan-cerny merged commit 7cced4f into ComplianceAsCode:master Feb 16, 2024
44 checks passed
@marcusburghardt marcusburghardt deleted the hide_not_complete_profiles_rhel branch February 16, 2024 12:36
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants