Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust 4.12 pci-dss-node assertion #12635

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Adjust 4.12 pci-dss-node master node assertion for rule file-permissions-var-log-kube-audit

Rationale:

@yuumasato yuumasato added the OpenShift OpenShift product related. label Nov 25, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@yuumasato
Copy link
Member Author

/test 4.12-e2e-aws-ocp4-pci-dss-node

@yuumasato
Copy link
Member Author

It looks like we have inconsistent behavior on rule file-permissions-var-log-kube-audit 😅

The latest weekly CI passed for ocp4-pci-dss-node:

    helpers.go:872: Result - Name: e2e-pci-dss-node-4-0-master-file-permissions-var-log-kube-audit - Status: INCONSISTENT - Severity: medium
    helpers.go:1060: Rule e2e-pci-dss-node-4-0-master-file-permissions-var-log-kube-audit matched expected result

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-ComplianceAsCode-content-master-4.12-e2e-aws-ocp4-pci-dss-node-4-weekly/1862934858938978304

@yuumasato yuumasato force-pushed the adjust_rule_assertions_25.11 branch from 67e39ab to ea04b50 Compare December 2, 2024 14:32
@yuumasato
Copy link
Member Author

/test 4.12-e2e-aws-ocp4-pci-dss-node

Copy link

codeclimate bot commented Dec 2, 2024

Code Climate has analyzed commit ea04b50 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato added this to the 0.1.76 milestone Jan 6, 2025
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Related context is in f32cacf

Looks like this wasn't included in the first PR since the 4.0 profile didn't exist, yet?

@rhmdnd rhmdnd merged commit 60a184a into ComplianceAsCode:master Jan 13, 2025
105 checks passed
@yuumasato yuumasato deleted the adjust_rule_assertions_25.11 branch January 15, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants