Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to regex for building scap delta tailoring files #12742

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 18, 2024

Description:

Adjust to regex for building scap delta tailoring files to build on RHEL 9 and remove RHEL 7 reference.

Rationale:

RHEL 9 has a STIG now and RHEL 7 is gone.

Review Hints

Build with

$ export ADDITIONAL_CMAKE_OPTIONS="-DSSG_BUILD_DISA_DELTA_FILES=ON"
$ ./build_product rhel8 rhel9

Review the files in build/rhel8/tailoring/rhel8_stig_delta_tailoring.xml and build/rhel9/tailoring/rhel9_stig_delta_tailoring.xml.

RHEL 9 has a STIG now and RHEL 7 is gone
@Mab879 Mab879 added the Infrastructure Our content build system label Dec 18, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Dec 18, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 18, 2024

Code Climate has analyzed commit 29babc4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Dec 18, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed review hints and I have checked that both tailoring files have been built.

@jan-cerny jan-cerny merged commit 3a794be into ComplianceAsCode:master Dec 18, 2024
105 checks passed
@Mab879 Mab879 deleted the adjust_delta_tailoring_regex branch December 18, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants