RHEL now checks no other users have primary group ID 0 #12891
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_accounts_root_gid_zero' differs.
--- oval:ssg-accounts_root_gid_zero:def:1
+++ oval:ssg-accounts_root_gid_zero:def:1
@@ -1,2 +1,3 @@
criteria AND
criterion oval:ssg-test_accounts_root_gid_zero:tst:1
+criterion oval:ssg-test_accounts_root_gid_zero_no_other_gid_0:tst:1 |
|
Code Climate has analyzed commit 68d4c9e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
I confirm this PR fixes the failing test other_user_uid_0.fail.sh on RHEL 9.
jcerny@fedora:~/work/git/scap-security-guide (pr/12891)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 accounts_root_gid_zero
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-01-24-1005/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_accounts_root_gid_zero
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script other_user_uid_0.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/12891)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --remediate-using ansible accounts_root_gid_zero
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-01-24-1007/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_accounts_root_gid_zero
INFO - Script correct_value.pass.sh using profile (all) OK
INFO - Script other_user_uid_0.fail.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
RHEL now checks no other users have primary group ID 0
Also make the test only work on RHEL and Ubuntu since those are the only platforms that have the OVAL test.
Rationale:
Fixes #12874