-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ubuntu2404] Fix rule 5.3.3.4.1 #12940
base: master
Are you sure you want to change the base?
Conversation
Hi @alanmcanonical. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0591704
to
8d8b9f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed
@@ -15,7 +15,7 @@ | |||
{{% if product in ["sle12", "sle15", "slmicro5"] %}} | |||
<ind:filepath operation="pattern match">^/etc/pam.d/.*$</ind:filepath> | |||
{{% elif 'ubuntu' in product %}} | |||
<ind:filepath operation="pattern match">^/etc/pam.d/common-password</ind:filepath> | |||
<ind:filepath operation="pattern match">^/etc/pam.d/common-(password|auth|account|session|session-noninteractive)$</ind:filepath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule is also used by Ubuntu 22.04 STIG but requires that only common-password
is checked. https://stigaview.com/products/ubuntu2204/v2r2/UBTU-22-611060/
Both 22.04 CIS v2 and 24.04 CIS v1 require that all of the above common-*
files are checked, so you might need to make a separate rule for CIS.
Check all nullok parameters in common-*
8d8b9f3
to
31f0f20
Compare
Code Climate has analyzed commit 31f0f20 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Description:
Rationale: