Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu2404] Fix rule 5.3.3.4.1 #12940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • [oval] Check all nullok parameters in common-*
  • [remediation/test] Remove all nullok parameters of pam_unix.so

Rationale:

  • Benchmark requires not only common-password to be checked but /etc/pam.d/common-{password,auth,account,session,session-noninteractive}

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 30, 2025
Copy link

openshift-ci bot commented Jan 30, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alanmcanonical alanmcanonical force-pushed the fix_53341 branch 2 times, most recently from 0591704 to 8d8b9f3 Compare January 30, 2025 18:11
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed

@@ -15,7 +15,7 @@
{{% if product in ["sle12", "sle15", "slmicro5"] %}}
<ind:filepath operation="pattern match">^/etc/pam.d/.*$</ind:filepath>
{{% elif 'ubuntu' in product %}}
<ind:filepath operation="pattern match">^/etc/pam.d/common-password</ind:filepath>
<ind:filepath operation="pattern match">^/etc/pam.d/common-(password|auth|account|session|session-noninteractive)$</ind:filepath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is also used by Ubuntu 22.04 STIG but requires that only common-password is checked. https://stigaview.com/products/ubuntu2204/v2r2/UBTU-22-611060/

Both 22.04 CIS v2 and 24.04 CIS v1 require that all of the above common-* files are checked, so you might need to make a separate rule for CIS.

Check all nullok parameters in common-*
Copy link

codeclimate bot commented Jan 30, 2025

Code Climate has analyzed commit 31f0f20 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys added Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates. CIS CIS Benchmark related. labels Jan 31, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 31, 2025
@dodys dodys self-assigned this Jan 31, 2025
@dodys dodys requested a review from a team January 31, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants