Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination for contract logs #318

Open
2 tasks
DOBEN opened this issue Dec 4, 2024 · 0 comments
Open
2 tasks

Pagination for contract logs #318

DOBEN opened this issue Dec 4, 2024 · 0 comments
Labels
[Type] Task An additional feature or improvement.

Comments

@DOBEN
Copy link
Member

DOBEN commented Dec 4, 2024

Task description

Currently, the front-end does not paginate the contract_logs (usually there are only a few) and the rust-backend uses some default pagination setting when generating the connection for the contract_logs rather than filling in the actual pagination info.

let mut connection = connection::Connection::new(true, true);

We might want to add pagination in the future and should update front-end/back-end accordingly for the three chain events that generate contract_logs.

  • Back-end update:
    Update the events and the events_as_hex function in the three chain events (contract initialization, contract interrupted and contract updated)

See comment (example for the contract interrupted chain event):
https://github.com/Concordium/concordium-scan/pull/317/files/59ee671424447f42812802def74aba12ec41611a#diff-dfdb365176fded8ddcc1eaa49b01daa4b66523e58aba199706b5c7f3a42b9b35

  • Front-end update:
@DOBEN DOBEN added the [Type] Task An additional feature or improvement. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Development

No branches or pull requests

1 participant