Add decoding of contract log events #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
force-pushed
the
add-decoding-of-contract_log-events-of-InterruptChainEvent
branch
from
adc1b4a to
59ee671
Compare
lassemand
reviewed
Dec 4, 2024
lassemand
reviewed
Dec 4, 2024
DOBEN
commented
Dec 4, 2024
backend-rust/src/graphql_api.rs
Outdated
| connection.edges.push(connection::Edge::new(index.to_string(), decoded_log)); | ||
| } | ||
|
|
||
| // Nice-to-have: pagination info but not used at front-end currently. |
There was a problem hiding this comment.
I changed the inline comment to TODO. I feel it is important to know why pagination is not handled here at the moment when reading the code.
lassemand
reviewed
Dec 4, 2024
lassemand
reviewed
Dec 4, 2024
lassemand
reviewed
Dec 4, 2024
DOBEN
force-pushed
the
add-decoding-of-contract_log-events-of-InterruptChainEvent
branch
from
b6705b8 to
ffc24b8
Compare
lassemand
approved these changes
Dec 4, 2024
DOBEN
deleted the
add-decoding-of-contract_log-events-of-InterruptChainEvent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add decoding of contract log events in interrupt chain events
Changes
Add decoding of contract log events in interrupt chain events