-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commission rate change indicators #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments. Not sure if the queries have to use the old commission names (probably do). Just as long as those don't appear in the GUI. That was probably in a different PR.
And when I change commission to 0%, the indicator/changes doesn't appear. |
Had wrong condition check which captured 0. Replaced with check on |
Purpose
Add commission rate change indicators.
Screen.Recording.2023-11-27.at.12.21.45.mov
https://concordium.atlassian.net/browse/CBW-1485
https://concordium.atlassian.net/browse/CBW-1484
Changes
Checklist
hard-to-understand areas.