Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commission rate change indicators #143

Merged
8 commits merged into from
Nov 27, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2023

Purpose

Add commission rate change indicators.

Screen.Recording.2023-11-27.at.12.21.45.mov

https://concordium.atlassian.net/browse/CBW-1485
https://concordium.atlassian.net/browse/CBW-1484

Changes

  • Add commission rate change indicators to overview and details page
  • Fix two wrong usage of “Baker"

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

@ghost ghost requested review from gitguillebetis and dg-concordium November 27, 2023 11:20
Copy link
Contributor

@dg-concordium dg-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. Not sure if the queries have to use the old commission names (probably do). Just as long as those don't appear in the GUI. That was probably in a different PR.

frontend/src/queries/useBakerListQuery.ts Outdated Show resolved Hide resolved
frontend/src/queries/useBakerQuery.ts Outdated Show resolved Hide resolved
frontend/src/queries/useBakerListQuery.ts Show resolved Hide resolved
frontend/src/queries/useBakerQuery.ts Show resolved Hide resolved
frontend/src/queries/useBakerQuery.ts Outdated Show resolved Hide resolved
@shjortConcordium
Copy link
Contributor

shjortConcordium commented Nov 27, 2023

When commission is 0% the display in the overview and details is weird:

Screenshot from 2023-11-27 14-15-21

Screenshot from 2023-11-27 14-14-59

@shjortConcordium
Copy link
Contributor

And when I change commission to 0%, the indicator/changes doesn't appear.

@ghost
Copy link
Author

ghost commented Nov 27, 2023

And when I change commission to 0%, the indicator/changes doesn't appear.

Had wrong condition check which captured 0. Replaced with check on undefined and null and validated it correctly renders 0 and the indicator.

@ghost ghost merged commit efe3563 into main Nov 27, 2023
1 check passed
@ghost ghost deleted the cbw-1484-1485/commission-rates-change branch November 27, 2023 17:50
@ghost ghost mentioned this pull request Nov 27, 2023
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants