Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health endpoint #442

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Health endpoint #442

merged 3 commits into from
Jan 30, 2025

Conversation

lassemand
Copy link
Contributor

@lassemand lassemand commented Jan 30, 2025 •
edited
Loading

Purpose

Health endpoint should return a none 200 status code given it is in a invalid state to comply with http probe.

Changes

Change status code on health endpoint
Add failed metrics counter on fetch on against the node collector backend

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

DOBEN
DOBEN approved these changes Jan 30, 2025
View reviewed changes
backend-rust/src/bin/ccdscan-api.rs Outdated Show resolved Hide resolved
backend-rust/src/bin/ccdscan-indexer.rs Outdated Show resolved Hide resolved
backend-rust/src/bin/ccdscan-indexer.rs Outdated Show resolved Hide resolved
@lassemand lassemand merged commit 2a81136 into main Jan 30, 2025
3 checks passed
@lassemand lassemand deleted the lma/fix/health branch January 30, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lassemand @DOBEN