-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity proofs #13
Identity proofs #13
Conversation
…ntity-proofs # Conflicts: # app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectView.kt # app/src/main/res/values/strings.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check out the comments.
I've also found the following issues when testing the feature locally:
- When account selector is opened for ID proof and you dismiss the sheet by swiping it down, "Could not send response" message is shown instead of rejecting the request;
1.1 When account selector is opened for ID proof and you press Back button (or gesture), session proposal is opened instead returning to the ID proof; - When I click "Approve" there is a delay before closing the sheet (global params are loading). If the params are not to be changed during request review, I think it is better to load them prior to showing the request, as it is done for smart contract calls;
- Not sure if it is a proof checker or the app issue, but if I select that only Notabene and DTS are allowed, the request can be proved with Concordium testnet IP anyway;
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/WalletConnectViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/DisplayStatements.kt
Show resolved
Hide resolved
app/src/main/java/com/concordium/wallet/ui/walletconnect/DisplayStatements.kt
Outdated
Show resolved
Hide resolved
|
Note that Jakob changed the wallet connect method name, so if you pull this, you also need to pull in the web3-id repo, for the proof explorer to keep working. |
Purpose
Support identity proofs.
This can be tested with the proof explorer (Currently one needs to use the
enable-wallet-connect
branch):https://github.com/Concordium/concordium-web3id/tree/enable-wallet-connect/test-tools/proof-explorer
This have been added
Changes
Checklist
hard-to-understand areas.