Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub build pipelines #14

Merged
merged 18 commits into from
Mar 21, 2024
Merged

GitHub build pipelines #14

merged 18 commits into from
Mar 21, 2024

Conversation

Radiokot
Copy link
Member

@Radiokot Radiokot commented Mar 20, 2024

Purpose

Added pipelines for internal testing and release builds, using secrets from the GitHub environment.
https://linear.app/concordium/issue/WAL2-71/cryptox-android-create-build-workflow-on-github

Changes

  • Add internal testing pipeline that runs for -qa and -rc tags. It builds signed APKs for 3 networks and publishes them for internal testing in Firebase;
  • Add release build pipeline that runs for X.Y.Z tags. It builds signed APKs and bundles for Mainnet and Testnet, for Google Play upload and standalone release;
  • All the signing keys are merged into signing.jks. Sensitive keys are protected with passwords set in the GitHub environment.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

@Radiokot Radiokot requested a review from lassemand March 20, 2024 13:12
Copy link

@lassemand lassemand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, which you can take or leave.

Good job, looks good to me

.github/workflows/release_build.yml Show resolved Hide resolved
.github/workflows/release_build.yml Show resolved Hide resolved
@Radiokot Radiokot merged commit e3d086f into main Mar 21, 2024
1 check passed
@Radiokot Radiokot deleted the feature/build_pipelines branch March 21, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants