Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL2-85 Fix crash on validator setup flow #29

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Radiokot
Copy link
Member

Purpose

The crash was caused by missing Serializable marker on SimpleFraction, introduced with WC cost estimation fix.

Changes

  • Add missing Serializable marker on SimpleFraction

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.

The crash was caused by missing Serializable marker on SimpleFraction.
Copy link

linear bot commented Apr 23, 2024

WAL2-85 CryptoX-Android App is crashing while adding new validator

To reproduce:

  1. Recover from seed phrase on Testnet.
  2. Add validator with stake 10000 CCDs.

Result:

App crashes before proceeding to commission rates screen.

Expected:

After setting commission rates, user can add validator.

Environment:

0.7.0-qa.8 - Android 11

add-validator.mp4

@Radiokot Radiokot changed the title Fix crash on validator setup flow WAL2-85 Fix crash on validator setup flow Apr 23, 2024
@Radiokot Radiokot requested a review from ramakser April 23, 2024 13:21
@Radiokot Radiokot merged commit 675a561 into main Apr 23, 2024
1 check passed
@Radiokot Radiokot deleted the fix/WAL2-85-validator-setup-crash branch April 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants