Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small changes in the Source Auth configuration #71

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Some small changes in the Source Auth configuration #71

merged 5 commits into from
Nov 21, 2024

Conversation

WilcoLouwerse
Copy link
Contributor

No description provided.

rjzondervan
rjzondervan requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rjzondervan rjzondervan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks OAuth, as OAuth requires a whole different set of authentication parameters.

@rjzondervan
Fixes from PR tests
0aea3ff 
- Dynamically decide which parameters must be passed on, as OAuth requires completely different authentication parameters compared to jwt
- Checking if the required parameters are set is already done by the authentication service depending on the flavor of authentication that is chosen.
rjzondervan
rjzondervan approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rjzondervan rjzondervan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewritten the way the authentication parameters are read to allow for more dynamic handling. Also, checking required authentication parameters is done depending on the flavour of authentication in the AuthenticationService already.

bbrands02
bbrands02 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@bbrands02 bbrands02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succesvol getest

@remko48 remko48 merged commit 1298da5 into development Nov 21, 2024
2 checks passed
@remko48 remko48 deleted the feature/CONNECTOR-77/auth-open-zaak branch November 21, 2024 10:39
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzondervan rjzondervan rjzondervan approved these changes

@bbrands02 bbrands02 bbrands02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WilcoLouwerse @rjzondervan @bbrands02 @remko48