Merge pull request #200 from Confidenceman02/issue/198

Avoid creating redundant List with all menu items
Confidenceman02 · Jan 19, 2025 · 2e3c124 · 2e3c124
2 parents d2bf008 + 1141d87
commit 2e3c124
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/Select.elm b/src/Select.elm
@@ -2324,16 +2324,15 @@ viewVirtual (Config config) =
                         adjustedItem =
                             applyVirtualConfigMenuItem idx virtualConfig.height mi
                     in
-                    Tuple.mapBoth ((::) adjustedItem) (Array.push adjustedItem) acc
+                    Array.push adjustedItem acc
                 )
-                ( [], Array.empty )
+                Array.empty
                 filteredMenuItems
                 |> sliceItems
-                |> Tuple.first
                 |> setVirtualMenuItems config.menuItems
 
-        sliceItems ( _, cache ) =
-            ( Array.slice startIndex (stopIndex + 1) cache |> Array.toList, cache )
+        sliceItems cache =
+            Array.slice startIndex (stopIndex + 1) cache |> Array.toList
 
         startIndexForOffset : Int
         startIndexForOffset =