Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting traces-limits #696

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adjusting traces-limits #696

wants to merge 2 commits into from

Conversation

Filter94
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Filter94 Filter94 temporarily deployed to docker-build-and-e2e February 17, 2025 13:22 — with GitHub Actions Inactive
@Filter94 Filter94 changed the title Setting some limits to 0 Adjusting traces-limits Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.41%. Comparing base (d50e814) to head (6f134b2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #696      +/-   ##
============================================
+ Coverage     68.38%   68.41%   +0.03%     
  Complexity     1185     1185              
============================================
  Files           323      323              
  Lines         13131    13131              
  Branches       1319     1319              
============================================
+ Hits           8979     8984       +5     
+ Misses         3600     3597       -3     
+ Partials        552      550       -2     
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø) Carriedforward from 621b52d
kotlin 66.07% <ø> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we don't have RIP limit in this file ?

LGTM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Let me set it to 0 as well

@Filter94 Filter94 temporarily deployed to docker-build-and-e2e February 17, 2025 13:35 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants