refactor: Remove prover support for v0 blobs #711
+159
−3,286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tabaie
commented
Feb 19, 2025
Tabaie
commented
- Maintain the v0 decompressor
- Remove the v0 decompression circuit
- Remove the v0 compressor
- Group blob decompression responses into an object
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
============================================
+ Coverage 68.37% 68.54% +0.17%
+ Complexity 1197 1179 -18
============================================
Files 326 323 -3
Lines 13326 13007 -319
Branches 1350 1313 -37
============================================
- Hits 9111 8916 -195
+ Misses 3658 3544 -114
+ Partials 557 547 -10
*This pull request uses carry forward flags. Click here to find out more. |
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
gbotrel
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
lgtm 👍
I see no reasons to keep v0 prover around, but maybe @AlexandreBelling you do?
Tabaie
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Tabaie
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.