feat: Remove stale validator keys during reload #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmansaleem
added
the
doc-change-required
signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
Outdated
Show resolved
Hide resolved
jframe
requested changes
Jan 16, 2025
signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/tech/pegasys/web3signer/slashingprotection/PostLoadingValidatorsProcessor.java
Outdated
Show resolved
Hide resolved
…ng logic to avoid clearing the map. Also made sure maps are thread-safe by using concurrent maps
jframe
reviewed
Jan 20, 2025
CHANGELOG.md
Outdated
Comment on lines
7
to
11
| The reload API call will remove all in-memory keys before loading them again using configuration files and bulk loading. | ||
| This unfortunately results in behaviour change of local configuration files pointing to encrypted keystores. Previously | ||
| cached local configuration files were avoided being reloaded during reload API call, now they will be reloaded and | ||
| reparsed. To keep the old behavior `--reload-keep-stale-keys=true` option can be used which will not remove stale keys | ||
| during reload API call. |
There was a problem hiding this comment.
Is this still true after the latest changes?
There was a problem hiding this comment.
The wording need to change a bit, but we are still loading all the local keystores during the reload because otherwise we won't be able to figure out which keystores are removed. Let me go through the local keystores logic again.
jframe
reviewed
Jan 20, 2025
signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
Show resolved
Hide resolved
jframe
reviewed
Jan 28, 2025
| @@ -45,216 +47,204 @@ | |||
| import org.apache.logging.log4j.LogManager; | |||
| import org.apache.logging.log4j.Logger; | |||
|
|
|||
| /** | |||
| * The SignerLoaded loads the metadata files and converts them to ArtifactSigners. This class keeps | |||
There was a problem hiding this comment.
Suggested change
| * The SignerLoaded loads the metadata files and converts them to ArtifactSigners. This class keeps | |
| * The SignerLoader loads the metadata files and converts them to ArtifactSigners. This class keeps |
jframe
approved these changes
Jan 28, 2025
usmansaleem
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Remove stale validator keys during reload API call. The stale keys will not be listed in public keys API call after reload. They are also disabled in slashing database in eth2 mode.
Fixed Issue(s)
Fixes #1018
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing