review code of torrentfs #63
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 22.68% 22.92% +0.23%
==========================================
Files 13 13
Lines 2081 2068 -13
==========================================
+ Hits 472 474 +2
+ Misses 1543 1528 -15
Partials 66 66
Continue to review full report at Codecov.
|
|
Yes the more the better |
ShadowErii
changed the title
compress/compress_test.go
Outdated
| ) | ||
|
|
||
| func SnappyEncode(data []byte) ([]byte, error) { |
There was a problem hiding this comment.
it seems that was just used for test
There was a problem hiding this comment.
it seems that was just used for test
Oh no , it is the same with zip, another compress method but not used now.
There was a problem hiding this comment.
There was a problem hiding this comment.
You can just add some comment above them to fix the linter
There was a problem hiding this comment.
ok, i thought it was just to test zip can figure out the same result
compress/compress.go
Outdated
| @@ -3,15 +3,14 @@ package compress | |||
| import ( | |||
| "bytes" | |||
| "compress/gzip" | |||
| "github.com/CortexFoundation/CortexTheseus/log" | |||
| "github.com/golang/snappy" | |||
| clog "github.com/CortexFoundation/CortexTheseus/log" | |||
Is it necessary to add test for these simple funcs like this to increse the coverage?