-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release/2.2 #2275
Merge release/2.2 #2275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to transfer publishing permissions for cosmwasm-vm-derive
:P
(re. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One extra comment to consider, but not necessary to be implemented
@@ -16,7 +16,7 @@ ark-bls12-381 = "0.4.0" | |||
ark-ec = { version = "0.4.2", features = ["parallel"] } | |||
ark-ff = { version = "0.4.2", features = ["asm", "parallel"] } | |||
ark-serialize = "0.4.2" | |||
cosmwasm-core = { version = "2.1.3", path = "../core" } | |||
cosmwasm-core = { version = "2.2.0-rc.1", path = "../core" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We can consider using [workspace.dependencies]
section in the main Cargo.toml file for CW related crates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. We can do this separately and see if we encounter any problems. This PR is really just intended to get the changes I had to do for the 2.2-rc release into main.
Had to fix the CI and make cargo-release happy