This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
Add cw1 section and subkeys doc #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Aug 24, 2020
| skip this section and go to the [next page](./setup.md) | ||
| ::: | ||
|
|
||
| ## Base |
There was a problem hiding this comment.
This is cut-and-paste from the README, right?
That is fine (and nit to publicize this more), but we need to note to update this if I update the spec (add iterator to list all accounts for example)
There was a problem hiding this comment.
Then we make sure documentation pipeline is attentive.
cw-plus/cw1/subkeys.md
Outdated
|
|
||
| ```ts | ||
| // contract is already uploaded on coralnet: codeId -> 12 | ||
| // const codeId = await factory.upload(); |
There was a problem hiding this comment.
Maybe remove some of the comments (the one explaining codeId -> 12 is good, the others confusing)
cw-plus/cw1/subkeys.md
Outdated
| // contract is already uploaded on coralnet: codeId -> 12 | ||
| // const codeId = await factory.upload(); | ||
| const { address } = await client.getAccount() | ||
| // contract.contractAddress -> 'coral1267wq2zk22kt5juypdczw3k4wxhc4z47mug9fd' |
There was a problem hiding this comment.
Although printing this out and a comment on how to reconnect later (not making a new one) is a good advice
| contract.freeze() | ||
| ``` | ||
|
|
||
| Let's give some allowance to your friends account, so he can buy a lambo: |
cw-plus/cw20/advanced.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| title: Advanced Usage | |||
| order: 3 | |||
| order: 4 | |||
There was a problem hiding this comment.
Maybe this belongs in "Overview" or "General" as these tips are valid for all contracts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CosmWasm/testnets#51
Resolves #83
I kept it simple and language is funny. I can make it formal if requested.