feat: Update MultiTest to 2.2.0 #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/replies #453 +/- ##
================================================
+ Coverage 72.17% 72.36% +0.18%
================================================
Files 63 63
Lines 3810 3825 +15
================================================
+ Hits 2750 2768 +18
+ Misses 1060 1057 -3 ☔ View full report in Codecov by Sentry. |
jawoznia
force-pushed
the
jawoznia/feat/update-multitest
branch
from
a551baf to
180165a
Compare
kulikthebird
reviewed
Nov 8, 2024
sylvia/tests/reply_dispatch.rs
Outdated
| #[sv::payload(raw)] _payload: Binary, | ||
| // _first_part_payload: u32, | ||
| // _second_part_payload: String, | ||
| _first_part_payload: u32, |
There was a problem hiding this comment.
We could make sure that the deserialization works as expected here
sylvia/tests/reply_dispatch.rs
Outdated
| // Payload is not currently forwarded in the MultiTest. | ||
| // _instantiate_payload: InstantiatePayload, | ||
| #[sv::payload(raw)] _payload: Binary, | ||
| _instantiate_payload: InstantiatePayload, |
There was a problem hiding this comment.
We could make sure that the deserialization works as expected here
Uncomment auto deserialization of payload in tests. Add test case for deserialization of custom data type.
jawoznia
force-pushed
the
jawoznia/feat/update-multitest
branch
from
22d82ed to
da4a273
Compare
kulikthebird
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncomment auto deserialization of payload in tests. Add test case for deserialization of custom data type.