Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr datasource is been added - Feature REVIEW #46

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

varadekd
Copy link
Contributor


Enter a brief description of the PR contents here
We have added a new datasource which is solr, this is added by creating a new query adapter that converts the es query to the solr based query. The main objective behind this PR is to share the code with @richard-jones and get the understanding that this is exactly what we discussed and this is the agreed style of our code.

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Sufficient testing has been carried out
  • Project's coding standards are met link
  • Code documentation and related non-code documentation has all been updated

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section can be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Sufficient testing has been carried out
  • Project's coding standards are met link
  • Code documentation and related non-code documentation has all been updated

Testing

List testing requirements/procedures

@varadekd varadekd merged commit 5a1b9ce into develop Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants