Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/documentation #1

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix/documentation #1

wants to merge 4 commits into from

Conversation

J4bbi
Copy link
Collaborator

@J4bbi J4bbi commented Aug 21, 2024 •
edited
Loading

This PR:

  • fixes typos and inaccuracies in examples in the READMEs
  • adds a bit of documentation on the recently added dependencies (see: redis, rabbitmq, opensearch, postgresql)
  • adds the confirm parameter to the creation of users in the init job
  • adds an optional create_fixtures parameter to the init job
  • lists the default sizes of the volume claims of the dependencies for increased transparency (see related issue)

@J4bbi J4bbi requested a review from Steven-Eardley August 21, 2024 12:24
Steven-Eardley
Steven-Eardley approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@Steven-Eardley Steven-Eardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Do we really need to specify the default 8Gi for all of these volumes?

@J4bbi J4bbi force-pushed the fix/documentation branch from 1cebcb2 to 79b95ac Compare August 26, 2024 10:09
J4bbi pushed a commit that referenced this pull request Dec 17, 2024
@Steven-Eardley
Merge pull request #1 from ImperialCollegeLondon/imperial_deployment
989b84d 
Imperial deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steven-Eardley Steven-Eardley Steven-Eardley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J4bbi @Steven-Eardley