Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairminter v2 #3070

Open
wants to merge 21 commits into
base: migration
Choose a base branch
from
Open

Fairminter v2 #3070

wants to merge 21 commits into from

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Mar 6, 2025

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft March 6, 2025 21:12
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (3c7a39e) to head (43f710e).

Additional details and impacted files
@@              Coverage Diff              @@
##           migration    #3070      +/-   ##
=============================================
+ Coverage      79.56%   80.29%   +0.73%     
=============================================
  Files            104      104              
  Lines          13701    13742      +41     
=============================================
+ Hits           10901    11034     +133     
+ Misses          2800     2708      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ouziel-slama ouziel-slama marked this pull request as ready for review March 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants